Require verified email address to accept a crate ownership invitation #11404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
eth3lbert
approved these changes
Jun 22, 2025
Contributor
eth3lbert
left a comment
eth3lbert
left a comment
There was a problem hiding this comment.
LGTM 👍
The crate_name seems to be used only when errors occur. I'm not sure if it's worth extracting it as a function and only calling it inside the error block. However, given that this should be a rare endpoint, I think it's also fine to keep it as is for now.
LawnGnome
approved these changes
Jun 22, 2025
Turbo87
force-pushed
the
verified-invites
branch
from
fa16340 to
9b9e6ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #6335, by returning errors to users with unverified email addresses that attempt to accept ownership invitations.